VB Scripts

[Longy]

I've got a script that deletes all files and folders in a folder that are older than 14 days. However I'm sure it used to work but it's stopped working.

Code:

'**************************************
' Name: Remove Files Older than 14 Days From Common Folder
'
'**************************************

Set fso = CreateObject("Scripting.FileSystemObject")
olddate = DateAdd("d", -14, date)

'wscript.stdout.writeline "Today is " & Date
'wscript.stdout.writeline "Deleting files unaccessed since " & olddate
'wscript.stdout.writeline " "
'wscript.stdout.writeline "Connecting To FileShare "
Set folder = fso.GetFolder("E:\Company Folder\CommonPool") '("\\<Server>\d$\temp\archive")' Get the folder
'WScript.StdOut.Writeline "Getting a List of the Files"
Set fc = folder.Files
For Each f1 In fc
if f1.DateLastModified < olddate Then
'wscript.stdout.write "Removing: " & f1.DateLastModified & vbtab & f1.name & VbCrLf
fso.deletefile(f1)
End if
Next

Does this seem correct? or am I missing something.

 

[Longy]

Ahh it seems to delete files and not folders - anyway to tweak it slightly?

 

[@Spoonie]

For Each SubFold In folder.SubFolders
If SubFold.DateLastModified < olddate Then
SubFold.Delete
EndIf
Next

You'll need to test it

http://msdn.microsoft.com/en-us/library/e1dthkks(VS.85).aspx

 

[Adamio]

Changing :

Set fc = folder.Files
For Each f1 In fc
if f1.DateLastModified < olddate Then
'wscript.stdout.write "Removing: " & f1.DateLastModified & vbtab & f1.name & VbCrLf
fso.deletefile(f1)
End if
Next

To :

For Each f1 In folder.Files
if f1.DateLastModified < olddate Then
'wscript.stdout.write "Removing: " & f1.DateLastModified & vbtab & f1.name & VbCrLf
fso.deletefile(f1)
End if
Next

Should do it (i think), i haven't done a vbs for a while and i've not got time to test it at the moment.

 

[Adamio]

Sorry didn't read it properly

As above, to do folders you'd use

For Each f1 In folder.subFolders
if f1.DateLastModified < olddate Then
'wscript.stdout.write "Removing: " & f1.DateLastModified & vbtab & f1.name & VbCrLf
fso.deletefolder(f1)
End if
Next

 

[Longy]

Cheers guys I've tried

'**************************************
' Name: Remove Files Older than 14 Days From Common Folder
'
'**************************************

Set fso = CreateObject("Scripting.FileSystemObject")
olddate = DateAdd("d", -14, date)

'wscript.stdout.writeline "Today is " & Date
'wscript.stdout.writeline "Deleting files unaccessed since " & olddate
'wscript.stdout.writeline " "
'wscript.stdout.writeline "Connecting To FileShare "
Set folder = fso.GetFolder("E:\Company Folder\CommonPool") '("\\<Server>\d$\temp\archive")' Get the folder
'WScript.StdOut.Writeline "Getting a List of the Files"
For Each f1 In folder.subFolders
if f1.DateLastModified < olddate Then
'wscript.stdout.write "Removing: " & f1.DateLastModified & vbtab & f1.name & VbCrLf
fso.deletefolder(f1)
End if
Next

doesn't seem to work

 

[Adamio]

Cheers guys I've tried

'**************************************
' Name: Remove Files Older than 14 Days From Common Folder
'
'**************************************

Set fso = CreateObject("Scripting.FileSystemObject")
olddate = DateAdd("d", -14, date)

'wscript.stdout.writeline "Today is " & Date
'wscript.stdout.writeline "Deleting files unaccessed since " & olddate
'wscript.stdout.writeline " "
'wscript.stdout.writeline "Connecting To FileShare "
Set folder = fso.GetFolder("E:\Company Folder\CommonPool") '("\\<Server>\d$\temp\archive")' Get the folder
'WScript.StdOut.Writeline "Getting a List of the Files"
For Each f1 In folder.subFolders
if f1.DateLastModified < olddate Then
'wscript.stdout.write "Removing: " & f1.DateLastModified & vbtab & f1.name & VbCrLf
fso.deletefolder(f1)
End if
Next

doesn't seem to work

Try changing

fso.deletefolder(f1)

To :

fso.deletefolder f1

 

[Longy]

I think that's solved it! Great, thank you.