PHP code headache

[Alex H]

Keep getting the "Error Editing" message, which is really really annoying me as I can't see what's wrong. This page is posted an array from a previous page, which is 'print_r'ing correctly. It breaks before the update. Have I missed something really obvious?

    if (isset($_POST[id])){
                print_r ($_POST);
                print_r ($_GET);
            //update
            $queryupd = "UPDATE products SET name = '$_POST[name]', price = '$_POST[price]', stock = '$_POST[stock]', desc = '$_POST[desc]', category = '$_POST[category]' WHERE id = '$_POST[id]'";
            $resultupd = mysql_query($queryupd);
            //update the entry
            if($resultupd){
            $message = "Product Edited!";
            header("Location: editProduct.php?message=$message");
            }else{
            $message = "Error Editing!";
echo $message;
            };
    }else{
        echo 'id not set';
                };

 

[iain187]

maybe something to do with the space in message? try $message = "Product%20Edited!";

or maybe

header("Location: editProduct.php?message=".$message);

I'm no expert, just guessing really!

 

[Alex H]

maybe something to do with the space in message? try $message = "Product%20Edited!";

or maybe

header("Location: editProduct.php?message=".$message);

I'm no expert, just guessing really!

The messages are working fine, it's the UPDATE that's not working.

 

[iain187]

surely if you are getting "error editing" then it is failing on the first part of that particular if statement?

anyway if you are certain your query has a fault then do this:

$resultupd = mysql_query($queryupd) or echo mysql_error();


at least I think that is the function that will tell you what is wrong in your query.

 

[Alex H]

This is the line that's breaking the code:

if($resultupd){

because the query is not execting.

I've just tried a cutdown query of:

$queryupd = "UPDATE products SET name = '$_POST[name]' WHERE id = '$_POST[id]'";

and this has NOT worked fine - says "Product Edited" but values in DB are unchanged ahhhhhhhh!

 

[Alex H]

Most of it is updating, i'm just not allowed to update the "desc" field for whatever reason

 

[iain187]

hmm, not something daft like an odd capital letter somewhere else?

 

[Alex H]

hmm, not something daft like an odd capital letter somewhere else?

Nah, it's something more sinister. Something to do with the data types I think. Got myself another week to finish it, so will get it sorted. Cheers for bouncing ideas though!

 

[KDF]

Keep getting the "Error Editing" message, which is really really annoying me as I can't see what's wrong. This page is posted an array from a previous page, which is 'print_r'ing correctly. It breaks before the update. Have I missed something really obvious?

    if (isset($_POST[id])){
                print_r ($_POST);
                print_r ($_GET);
            //update
            $queryupd = "UPDATE products SET name = '$_POST[name]', price = '$_POST[price]', stock = '$_POST[stock]', desc = '$_POST[desc]', category = '$_POST[category]' WHERE id = '$_POST[id]'";
            $resultupd = mysql_query($queryupd);
            //update the entry
            if($resultupd){
            $message = "Product Edited!";
            header("Location: editProduct.php?message=$message");
            }else{
            $message = "Error Editing!";
echo $message;
            };
    }else{
        echo 'id not set';
                };

Try,

    if (isset($_POST[id])){
                print_r ($_POST);
                print_r ($_GET);
            //update
            $queryupd = "UPDATE products SET name = '".$_POST[name]."', price = '".$_POST[price]."', stock = '".$_POST[stock]."', desc = '".$_POST[desc]."', category = '".$_POST[category]."' WHERE id = '".$_POST[id]."'";
            $resultupd = mysql_query($queryupd) or die("Error: Your Query: " . $queryupd . "<br /> Error: (" . mysql_errno() . ") " . mysql_error());
            //update the entry
            if($resultupd){
            $message = "Product Edited!";
            header("Location: editProduct.php?message=$message");
            }else{
            $message = "Error Editing!";
echo $message;
            };
    }else{
        echo 'id not set';
                };

I've enclosed the variables and if that doesn't fix it i've added a 'or die' clause to the mysql query that will give you an informative error message on failure, post that error message up here and i will be able to help you.

Also you should encode the data coming in to stop sql injection attacks, but if its just a demo script you wont need that.