Anyone here program in C?

[FincH]

Hi.

I'm doing an assingment for college but currently stuck on an IF staement within my program.

Basicaly instead of running the IF the staement the program seems to ignore it and go straight to the end of the program (Press any key to continue).

#include <stdio.h>
#include <stdlib.h>

int main(void)
{
char surname[30];
char initial[1];
char dob[8];
int choice;

printf("Please enter your surname: ");
scanf("%s", surname);
printf("Please enter your initial: ");
scanf("%s", initial);
printf("Please enter your date of birth in the DD/MM/YYYY format: ");
scanf("%d", dob);
system("cls");
printf("1 - Arithmetic \n");
printf("2 - Conversion \n");
printf("3 - Result \n");

printf("Please choose a number to continue: ");
scanf("%d",choice);

if(choice==1)
{
system ("cls");
printf("You chose 1");
}
else if(choice==2)
{
system ("cls");
printf("You chose 2");
}
return(0);
}

It's fine up until the first part of the IF staement bu then on key press the program quits.

I'm very new to C so appolgies if the program is a bit crappy

Any ideas? Cheers.

 

[ollie_kerslake]

umm, can you include the entire code?

 

[b3nje]

pastebin!

 

[FincH]

That is all the code!

Like I say, was working finr untill I put the IF staement in.

This is C, not C++ I'm doing btw.

 

[ollie_kerslake]

it wont work as your not telling it what to do after the if statement runs, it has the answer but cant do anything with it.

 

[FincH]

Well I'm asking it to print their corresponding choice to the screen...or so I thought.

if(choice==1)
{
system ("cls");
printf("You chose 1");
}
else if(choice==2)
{
system ("cls");
printf("You chose 2");
}
return(0);
}

Surely that is telling it 'IF they choose 1 then print to screen "You chose 1" etc'?

Gay programming

 

[ollie_kerslake]

Yeah it should work ok, sorry missed the printf

Does it actually print to screen before it closes

After the IF statement you have

return(0);

Try it without the brackets.

 

[ollie_kerslake]

also when I was programming at uni I used this site abit http://www.geocities.com/learnprogramming123/Clesson5Beginner.htm

 

[FincH]

Na removing the brackets doesn't help!

Cheers for the link Oli.

Still not working tho

 

[dick]

programming suck balls. have to do it in my course.

dont know why any1 wud want to be a computer programmer.

 

[ollie_kerslake]

cause the money is goooood I will have another look for ya finch

 

[Adamio]

Have you tried PlanetSourceCode ?

I only do VB and some C# so i'm probably not gonna be alot of help.

The only thing i wondered is if you've got multiple choices i would have thought you'd want a C equivalent to the 'switch' function in C# (or 'Select Case' in VB)

 

[Hotshot]

system ("cls");
printf("You chose 2");
}

does that not need an "end if" after the close bracket.

 

[Adamio]

The only thing i wondered is if you've got multiple choices i would have thought you'd want a C equivalent to the 'switch' function in C# (or 'Select Case' in VB)

In fact according to the MSDN the 'switch' keyword is used in C++ aswell.

 

[Capture_db]

i only know c# so may be talking out my arse here but how is your int choice being passed its intoformation??

 

[sn00p]

your scanf is wrong, should be passing a pointer to "choice" not the value.

 

[G_F]

Ahh, Programming, brings back happy memories