The only real concern I have over modern Macs is with their upgrade paths. I was genuinely shocked to learn that the MBP that my wife bought had its 8GB soldered-on to the motherboard. Whilst I appreciate the 'incentive' to spend more and go for the 16GB version initially, I just think that smacks of short-term logic and does little other than to piss off the end user. If in four or five years when additional memory might be required, why can I not upgrade it easily? Or more likely - the memory would probably fail in that interim period.
This isn't unique to Macs - I've seen the same cancerous attitude in several Windows-based laptops that we've bought through work - some really quite expensive too. But the first time I'd seen this done was on a MBP and is a bit of a sore point, given that the hardware is well known for its general longevity.
It's mainly because of the design aesthetics, making the laptops thinner means that things like RAM have to be soldered directly onto the board, there just isn't the space inside for stacked boards with connectors, I've also never had a Mac fail with a memory issue.
On my 2016 TB MBP the storage is soldered directly to the board for the very same reasons, but I have a f**k off NAS which I use to store stuff and important stuff on that is backed up to the cloud, 2 years ago when I bought this machine I opted for the 256GB version because I couldn't see me using any more than that, 2 years later I still haven't even used half of it.
At some point the storage will fail, it's flash, but I expect to have had my moneys worth out of the machine by then and it actually being at the point of time for an upgrade.
I have a 2010 13" MBP which was my daily driver until I got this one, it has upgradable memory and storage, but it's considerable heavier and chunkier than my current machine which is a 15"! I hated carrying the old MBP around because it weighed a ton.